Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

refactor : Replace 'blacklist' and 'whitelist' terms in repository #101

Closed
wants to merge 5 commits into from

Conversation

chetanugale
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes # googleapis/gapic-generator-python#1520 🦕

@chetanugale chetanugale requested review from a team as code owners August 11, 2021 07:14
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Aug 11, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2021
@chetanugale chetanugale changed the title Replace 'blacklist' and 'whitelist' terms in repository refactor : Replace 'blacklist' and 'whitelist' terms in repository Aug 11, 2021
@chetanugale
Copy link
Author

@parthea can we please get some inputs on this PR

@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 5, 2021
@tseaver
Copy link

tseaver commented Oct 5, 2021

@chetanugale This types.py file is generated from the proto messages in the googleapis-discovery repo. We have to keep our local version in sync with that file, which (I believe) is actually generated from the JSON file next to it. Perhaps you could open an issue in that repository and link it here.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2021
@chetanugale
Copy link
Author

@chetanugale This types.py file is generated from the proto messages in the googleapis-discovery repo. We have to keep our local version in sync with that file, which (I believe) is actually generated from the JSON file next to it. Perhaps you could open an issue in that repository and link it here.

googleapis/googleapis-discovery#66

@parthea
Copy link
Contributor

parthea commented Oct 13, 2021

Hi @chetanugale , I'm going to close this PR as the source file that needs to be changed lives in another repository.

@parthea parthea closed this Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants