-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Begin using new microgenerator for v2 firestore #91
Conversation
…nto onboard-microgen
Kokoro Test is Skipping System, which is odd, running locally. |
Coverage is at 97%, not 100%. Considering, temporarily, dropping this and filing an issue. Docs issue tbd. |
I recommend viewing a selection of commits to make this a bit more palatable: https://github.com/googleapis/python-firestore/pull/91/files/538cb05b70c96a637c1b12cf0c69a2925fc45686..94210e3625b63a40a7e76698eba529e8ab3da0a3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Most of the comments I had were clarifying confusion on my end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Commits early on split off to separate out generated bits from edits to (hopefully) ease reviewing