Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IS_NOT_NULL operator to filters #971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgraczyk
Copy link
Contributor

This allows filters like x.where("field", "!=", None) to work, matching the javascript implementation.

Also adds a test.

Fixes #970

@mgraczyk mgraczyk requested review from a team as code owners September 20, 2024 18:11
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/python-firestore API. labels Sep 20, 2024
@mgraczyk
Copy link
Contributor Author

In addition to the unit test, I tested this against my production firestore database and it returns the expected results.

@mgraczyk mgraczyk changed the title Implement IS_NOT_NULL operator for filters feat: add IS_NOT_NULL operator to filters Sep 20, 2024
@dconeybe dconeybe assigned daniel-sanche and unassigned dconeybe Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement IS_NOT_NULL
3 participants