Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: revert local changes to mypy #544

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE: revert local changes to mypy #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.OwlBot.lock.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest
digest: sha256:ec49167c606648a063d1222220b48119c912562849a0528f35bfb592a9f72737
digest: sha256:74124fe59b8859f30143dcdea7b78300046d97de816dc53c0e381308a5f4f8bc
18 changes: 1 addition & 17 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
BLACK_VERSION = "black==19.10b0"
BLACK_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]

MYPY_VERSION = "mypy==0.910"
PYTYPE_VERSION = "pytype==2021.4.9"


Expand All @@ -45,7 +44,6 @@
"lint",
"lint_setup_py",
"blacken",
"mypy",
"pytype",
"docs",
]
Expand All @@ -54,24 +52,10 @@
nox.options.error_on_missing_interpreters = True


@nox.session(python=DEFAULT_PYTHON_VERSION)
def mypy(session):
"""Run type checks with mypy."""
session.install("-e", ".")
session.install(MYPY_VERSION)

# Just install the type info directly, since "mypy --install-types" might require
# an additional pass.
session.install("types-protobuf", "types-setuptools")

# Check the hand-written layer.
session.run("mypy", "google/cloud")


@nox.session(python=DEFAULT_PYTHON_VERSION)
def pytype(session):
"""Run type checks."""
session.install("-e", ".")
session.install("-e", ".[all]")
session.install(PYTYPE_VERSION)
session.run("pytype")

Expand Down