Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported python versions in README to >= 3.6 #668

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

rajatbhatta
Copy link
Contributor

Update supported python versions in README to >= 3.6, in line with setup.py which indicates python_requires=">=3.6".

Update supported python versions in README to >= 3.6, in line with setup.py which indicates python_requires=">=3.6".
@rajatbhatta rajatbhatta requested review from a team as code owners January 20, 2022 11:33
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jan 20, 2022
@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 20, 2022
README.rst Show resolved Hide resolved
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2022
Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Python 3.5 has been deprecated. So, adding it to the list of deprecated versions.
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vi3k6i5 vi3k6i5 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 25, 2022
@vi3k6i5 vi3k6i5 merged commit 9329a10 into googleapis:main Jan 25, 2022
vi3k6i5 pushed a commit to vi3k6i5/python-spanner that referenced this pull request Mar 29, 2022
…is#668)

* chore: update supported python versions in README to >= 3.6

Update supported python versions in README to >= 3.6, in line with setup.py which indicates python_requires=">=3.6".

* chore: update the deprecated python versions in readme file

Python 3.5 has been deprecated. So, adding it to the list of deprecated versions.

Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants