Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for row_count in cursor. #675

Merged
merged 6 commits into from
Feb 4, 2022
Merged

fix: add support for row_count in cursor. #675

merged 6 commits into from
Feb 4, 2022

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Feb 2, 2022

Fixes googleapis/python-spanner-django#746 🦕

Undo the changes done in #603

@vi3k6i5 vi3k6i5 requested review from a team as code owners February 2, 2022 10:57
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 2, 2022
@vi3k6i5 vi3k6i5 marked this pull request as draft February 2, 2022 10:57
@vi3k6i5 vi3k6i5 marked this pull request as ready for review February 3, 2022 07:37
@vi3k6i5 vi3k6i5 requested a review from IlyaFaer February 4, 2022 07:29
@vi3k6i5 vi3k6i5 closed this Feb 4, 2022
@vi3k6i5 vi3k6i5 reopened this Feb 4, 2022
@dandhlee dandhlee added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 4, 2022
@vi3k6i5 vi3k6i5 merged commit d431339 into googleapis:main Feb 4, 2022
vi3k6i5 added a commit to vi3k6i5/python-spanner that referenced this pull request Mar 29, 2022
* fix: add support for row_count

* docs: update rowcount property doc

* fix: updated tests for cursor to check row_count

* refactor: lint fixes

* test: add test for do_batch_update

* refactor: Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-cloud-spanner version 3.12.0 has breaking changes for django tests
4 participants