Skip to content

Commit

Permalink
chore(python): Noxfile recognizes that tests can live in a folder (#696)
Browse files Browse the repository at this point in the history
* chore(python): Noxfile recognizes that tests can live in a folder

Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

* update owlbot.py to remove python 3.6 samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
  • Loading branch information
3 people authored Jan 19, 2022
1 parent 8789afa commit 46c3e66
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest
digest: sha256:ae600f36b6bc972b368367b6f83a1d91ec2c82a4a116b383d67d547c56fe6de3
digest: sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828
12 changes: 5 additions & 7 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@
#
# For syntax help see:
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
# Note: This file is autogenerated. To make changes to the codeowner team, please update .repo-metadata.json.

# @googleapis/yoshi-python @googleapis/cloud-storage-dpe are the default owners for changes in this repo
* @googleapis/yoshi-python @googleapis/cloud-storage-dpe

# The cloud-storage-dpe team is the default owner for anything not
# explicitly taken by someone else.
* @googleapis/cloud-storage-dpe @googleapis/yoshi-python

# Additionally, the python-samples-owners team is also among
# the default owners for samples changes.
/samples/ @googleapis/cloud-storage-dpe @googleapis/yoshi-python @googleapis/python-samples-owners
# @googleapis/python-samples-reviewers @googleapis/cloud-storage-dpe are the default owners for samples changes
/samples/ @googleapis/python-samples-reviewers @googleapis/cloud-storage-dpe
2 changes: 1 addition & 1 deletion owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"noxfile.py",
"renovate.json", # do not bundle reports
"CONTRIBUTING.rst",
".github/CODEOWNERS",
".kokoro/samples/python3.6", # remove python 3.6 support
],
)

Expand Down
1 change: 1 addition & 0 deletions samples/snippets/noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ def _session_tests(
) -> None:
# check for presence of tests
test_list = glob.glob("*_test.py") + glob.glob("test_*.py")
test_list.extend(glob.glob("tests"))
if len(test_list) == 0:
print("No tests found, skipping directory.")
else:
Expand Down

0 comments on commit 46c3e66

Please sign in to comment.