Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add retry conf s8 test cases and data integrity checks #702

Merged
merged 5 commits into from
Feb 25, 2022
Merged

tests: add retry conf s8 test cases and data integrity checks #702

merged 5 commits into from
Feb 25, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jan 24, 2022 •
edited
Loading

This adds scenario 8 and data integrity checks to the retry conformance tests

  • add s8 to test schema - tests downloads handle complex retries
  • instruction cases return-broken-stream and return-broken-stream-after-256K simulate interrupted media mid-stream
  • move fixtures to newly added conftest.py file
  • create a 16MB payload/object fixture file_data to test large file complex downloads (and later on resumable uploads)
  • add data integrity checks for downloads in the retry conf tests

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 24, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 24, 2022
@cojenco cojenco marked this pull request as ready for review January 24, 2022 18:05
@cojenco cojenco requested review from a team as code owners January 24, 2022 18:05
This was referenced Jan 24, 2022
Closed
Merged
@cojenco cojenco added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022
unforced
unforced approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@unforced unforced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cojenco cojenco merged commit c6bf78d into googleapis:main Feb 25, 2022
@cojenco cojenco deleted the retryconf-s8 branch November 16, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unforced unforced unforced approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cojenco @unforced @yoshi-kokoro