-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate native image metadata during tar assembly #1831
Conversation
…ative-image-gen-tar
|
||
#TODO: Use awk to extract classes inside java class. Such as: awk '/public class/' Classes.java | ||
if [[ {package_dir_path} == *proto-google-cloud-* ]] || [[ {package_dir_path} == *gapic-google-cloud-* ]] || [[ {package_dir_path} == *grpc-google-cloud-* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update this PR to:
- Also apply to Showcase client generation
- Invoke the showcase native image tests (free if rebasing on ci: showcase native check #1833)
- Remove the RunReachabilityHandlersConcurrently argument
- Remove the Feature classes using reachability handlers
…form-java into native-image-gen-tar
[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Closing in favor of #1841 |
This is an alternate approach to #1812. Instead of editing the Writer class, we are generating the reflect-config.json file at a later stage, i.e when the library tar is being assembled.
In this implementation:
The
_gapic_pkg_tar_impl
implementation package tar.gz files for proto-google-, gapic-google- and grpc-google-*. Before the compressed tarballs for each of these directories are created, we implement some logic tocom.google.cloud.speech.v2.SpeechClient
Local Testing
bazel build //google/cloud/speech/v2:google-cloud-speech-v2-java
to generate an compressed tar for the desired. client library.** TODOs**