Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not include optional dependencies in unmanaged dependency c… #2410

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Jan 23, 2024

In this PR:

  • Do not include optional dependencies in target BOM.
  • Update the unit test to verify newer version of java-bigtable BOM, from which exposed this issue.

Context: the unmanaged dependency check failed on java-bigtable even though no dependency is added (example PR).

The dependencies pointed out by the check is mockito-core and its dependencies (check log), which is used in testing and should not be reported by the check.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 23, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 23, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review January 23, 2024 02:07
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner January 23, 2024 02:07
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2024
@JoeWang1127 JoeWang1127 merged commit 909bdf9 into main Jan 23, 2024
40 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/update-unmanaged-dependency-check branch January 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants