Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update gapic-showcase to v0.33.0 #2653

Merged
merged 3 commits into from
Apr 22, 2024
Merged

deps: update gapic-showcase to v0.33.0 #2653

merged 3 commits into from
Apr 22, 2024

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Apr 17, 2024

update gapic-showcase so that we can pickup changes in googleapis/gapic-showcase#1484

Steps:

  1. Updated the gapic-showcase version in gapic-showcase/pom.xml to 0.33.0
  2. Ran mvn compile -P update

@zhumin8 zhumin8 requested a review from a team as a code owner April 17, 2024 20:15
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 17, 2024
@zhumin8 zhumin8 requested review from lqiu96 and alicejli April 17, 2024 20:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1.9% Coverage on New Code (required ≥ 80%)
60.4% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
50.0% Duplication on New Code

See analysis details on SonarCloud

@lqiu96
Copy link
Contributor

lqiu96 commented Apr 17, 2024

@burkedavison Do you remember what this showcase version value in the WORKSPACE file is for? https://github.com/googleapis/sdk-platform-java/blob/main/WORKSPACE#L110

Do we need to keep this updated/ is this used at all?

@zhumin8
Copy link
Contributor Author

zhumin8 commented Apr 17, 2024

2 failed cis:

  • showcase-clirr - okay to ignore according to deps: update gapic-showcase to v0.30.0 #2354 (comment)
  • [gapic-generator-java-root] sonarcloud.
    • For coverage on new code, other than api-version, most changes comes from proto change related to request-id. cc. @alicejli for context.
    • For duplication and reliability, consider these are generated code, Wonder what's our general approach here? cc. @lqiu96 @blakeli0

image

@lqiu96
Copy link
Contributor

lqiu96 commented Apr 17, 2024

For duplication and reliability, consider these are generated code, Wonder what's our general approach here?

I think it's fine for us to merge it in. We can't change the protoc generated code and the generated output from the gapic-generator probably needs a larger refactor to "fix".

@blakeli0
Copy link
Collaborator

@burkedavison Do you remember what this showcase version value in the WORKSPACE file is for? https://github.com/googleapis/sdk-platform-java/blob/main/WORKSPACE#L110

Do we need to keep this updated/ is this used at all?

I think we can probably remove the showcase section in WORKSPACE, we used to use Bazel to generate showcase client, but now we use hermetic build scripts, and the version is greped from the pom.

@zhumin8
Copy link
Contributor Author

zhumin8 commented Apr 22, 2024

@blakeli0 @lqiu96 Could you take another look?
I'd like to merge this in if it looks good.

lqiu96
lqiu96 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@lqiu96 lqiu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zhumin8 zhumin8 merged commit 0a71cbf into main Apr 22, 2024
34 of 36 checks passed
@zhumin8 zhumin8 deleted the update-showcase branch April 22, 2024 20:08
@release-please release-please bot mentioned this pull request Apr 22, 2024
Merged
alicejli pushed a commit that referenced this pull request May 2, 2024
@release-please
chore(main): release 2.40.0 (#2679)
42251c3 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](#2699))
([5bb9770](5bb9770))
* add a CLI tool to validate generation configuration
([#2691](#2691))
([f2ce524](f2ce524))
* Parser to consume the api-versioning value from proto
([#2630](#2630))
([40711fd](40711fd))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](#2671))
([e63d1b4](e63d1b4))


### Bug Fixes

* change folder prefix for adding headers
([#2688](#2688))
([4e92be8](4e92be8))
* Log HttpJson's async thread pool core size
([#2697](#2697))
([34b4bc3](34b4bc3))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](#2637))
([6d673f3](6d673f3))
* Return resolved endpoint from StubSettings' Builder
([#2715](#2715))
([32c9995](32c9995))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](#2681))
([3967a19](3967a19))
* update dependency absl-py to v2.1.0
([#2659](#2659))
([cae6d79](cae6d79))
* update dependency gitpython to v3.1.43
([#2656](#2656))
([208bef4](208bef4))
* update dependency lxml to v5.2.1
([#2661](#2661))
([b95ad49](b95ad49))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](#2703))
([87069bc](87069bc))
* update dependency typing to v3.10.0.0
([#2663](#2663))
([7fb5653](7fb5653))
* update gapic-showcase to v0.33.0
([#2653](#2653))
([0a71cbf](0a71cbf))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](#2682))
([42526dc](42526dc))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request May 22, 2024
@zhumin8 @lqiu96
deps: update gapic-showcase to v0.33.0 (#2653)
5227cd9 
update gapic-showcase so that we can pickup changes in
googleapis/gapic-showcase#1484

Steps: 
1) Updated the gapic-showcase version in `gapic-showcase/pom.xml` to
0.33.0
2) Ran `mvn compile -P update`
lqiu96 pushed a commit that referenced this pull request May 22, 2024
@release-please @lqiu96
chore(main): release 2.40.0 (#2679)
00f7d9c 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](#2699))
([5bb9770](5bb9770))
* add a CLI tool to validate generation configuration
([#2691](#2691))
([f2ce524](f2ce524))
* Parser to consume the api-versioning value from proto
([#2630](#2630))
([40711fd](40711fd))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](#2671))
([e63d1b4](e63d1b4))


### Bug Fixes

* change folder prefix for adding headers
([#2688](#2688))
([4e92be8](4e92be8))
* Log HttpJson's async thread pool core size
([#2697](#2697))
([34b4bc3](34b4bc3))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](#2637))
([6d673f3](6d673f3))
* Return resolved endpoint from StubSettings' Builder
([#2715](#2715))
([32c9995](32c9995))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](#2681))
([3967a19](3967a19))
* update dependency absl-py to v2.1.0
([#2659](#2659))
([cae6d79](cae6d79))
* update dependency gitpython to v3.1.43
([#2656](#2656))
([208bef4](208bef4))
* update dependency lxml to v5.2.1
([#2661](#2661))
([b95ad49](b95ad49))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](#2703))
([87069bc](87069bc))
* update dependency typing to v3.10.0.0
([#2663](#2663))
([7fb5653](7fb5653))
* update gapic-showcase to v0.33.0
([#2653](#2653))
([0a71cbf](0a71cbf))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](#2682))
([42526dc](42526dc))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@alicejli alicejli Awaiting requested review from alicejli

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhumin8 @lqiu96 @blakeli0