Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw exception when user attempt to override api-version header. #2745

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented May 7, 2024

As discussed offline, amend behavior so that if user code attempt to override api-version header via user header, conflict resolution in ClientContext would throw exception. This is consistent whether service itself sets api-version in proto or not (or empty).

TODO: when #2737 gets in, add a test case to ITApiVersionHeaders.java where attempts setHeaderProvider() and exception throws.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 7, 2024
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant