feat(gax): add protobuf version tracking to headers #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldetmer
force-pushed
the
protobuf-metric
branch
from
ccdd15d
to
ea7e7ec
Compare
ldetmer
changed the title
ldetmer
changed the title
gax-java/gax/src/main/java/com/google/api/gax/core/GaxProperties.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/ApiClientHeaderProvider.java
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/core/GaxProperties.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/ApiClientHeaderProvider.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/ApiClientHeaderProvider.java
Show resolved
Hide resolved
|
LGTM w/ addition of Showcase tests showing gRPC + httpjson clients are both providing the new headers. Looking for approval from @blakeli0 |
blakeli0
reviewed
Sep 16, 2024
gax-java/gax/src/test/java/com/google/api/gax/rpc/ApiClientHeaderProviderTest.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/core/GaxProperties.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/core/GaxProperties.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/ApiClientHeaderProvider.java
Outdated
Show resolved
Hide resolved
gax-java/gax/src/main/java/com/google/api/gax/rpc/ApiClientHeaderProvider.java
Outdated
Show resolved
Hide resolved
| Pattern.compile("gl-java/.+ gapic/.+--protobuf-.+ gax/.+ rest/ protobuf/.*"); | ||
| httpJsonClient.echo(EchoRequest.newBuilder().build()); | ||
| ArrayList headerValues = | ||
| (ArrayList) httpJsonInterceptor.metadata.getHeaders().get(HTTP_CLIENT_API_HEADER_KEY); |
There was a problem hiding this comment.
Rather than using raw-types, use ArrayList<?> if you don't know the type. In this case, we're casting to String in the next line so we might as well cast to ArrayList<String>
|
Thank you for the showcase tests - LGTM. |
blakeli0
added
the
do not merge
|
Adding |
Understood about DNM, but is this verbally LGTM? |
burkedavison
approved these changes
Sep 20, 2024
blakeli0
approved these changes
Oct 15, 2024
blakeli0
removed
the
do not merge
|
|
mpeddada1
pushed a commit
that referenced
this pull request
Oct 22, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>2.48.0</summary> ## [2.48.0](v2.47.0...v2.48.0) (2024-10-22) ### Features * **gax:** add protobuf version tracking to headers ([#3199](#3199)) ([40c19b1](40c19b1)) * selectively generate libraries ([#3290](#3290)) ([dfe1a50](dfe1a50)) ### Bug Fixes * generator setting incorrect name/class for sample due to region tag (2nd attempt) ([#3293](#3293)) ([771bd0e](771bd0e)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.34.0 ([#3303](#3303)) ([5b01274](5b01274)) * update dependency com.google.errorprone:error_prone_annotations to v2.34.0 ([#3304](#3304)) ([5bd6c9c](5bd6c9c)) * update google api dependencies ([#3282](#3282)) ([a9eac85](a9eac85)) * update google auth library dependencies to v1.29.0 ([#3302](#3302)) ([e64eda2](e64eda2)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Java client libraries to report the runtime version of Protobuf as part of the existing x-goog-api-client request header.
Tested: java-cloud-library api (billing) and hand written api (storage)