[ggj][bazel][goldens] fix: refactor and fix bazel golden_update rules #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
xiaozhenliu-gg5
approved these changes
Oct 3, 2020
| srcs = srcs, | ||
| data = data, | ||
| main_class = "com.google.api.generator.test.framework.SingleJUnitTestRunner", | ||
| deps = ["//src/test/java/com/google/api/generator/test/framework:junit_runner"] + deps, | ||
| ) |
There was a problem hiding this comment.
Can you explain a little bit why the def junit_output_zip is replaced by the native.java_binary and it will make the build running before running overwrite_golden? Thanks
summer-ji-eng
pushed a commit
that referenced
this pull request
Oct 7, 2020
…#363) * fix: use imperative bazel rule names * fix: refactor and fix bazel golden_update rules
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.grpc:grpc-protobuf](https://togithub.com/grpc/grpc-java) | `1.45.1` -> `1.46.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>grpc/grpc-java</summary> ### [`v1.46.0`](https://togithub.com/grpc/grpc-java/releases/v1.46.0) ##### Bug Fixes - netty: Fixed incompatibility with Netty 4.1.75.Final that caused COMPRESSION_ERROR ([#​9004](https://togithub.com/grpc/grpc-java/issues/9004)) - xds: Fix LBs blindly propagating control plane errors ([#​9012](https://togithub.com/grpc/grpc-java/issues/9012)). This change forces the use of UNAVAILABLE for any xDS communication failures, which otherwise could greatly confuse an application. This is essentially a continuation of the fix in 1.45.0 for XdsNameResolver, but for other similar cases - xds: Fix ring_hash reconnecting behavior. Previously a TRANSIENT_FAILURE subchannel would remain failed forever - xds: Fix ring_hash defeating priority’s failover connection timeout. [grpc/proposal#​296](https://togithub.com/grpc/proposal/issues/296) - binder: Work around an Android Intent bug for consistent AndroidComponentAndress hashCode() and equals() ([#​9061](https://togithub.com/grpc/grpc-java/issues/9061)) - binder: Fix deadlock when using process-local Binder ([#​8987](https://togithub.com/grpc/grpc-java/issues/8987)). Process-local binder has a different threading model than normal FLAG_ONEWAY, so this case is now detected and the FLAG_ONEWAY threading model is emulated - okhttp: Removed dead code in io.grpc.okhttp.internal.Util. This should have no impact except for static code analysis. This code was never used and was from the process of forking okhttp. It calculated things like MD5 which can trigger security scanners ([#​9071](https://togithub.com/grpc/grpc-java/issues/9071)) ##### Behavior Changes - java_grpc_library.bzl: Pass use_default_shell_env = True for protoc ([#​8984](https://togithub.com/grpc/grpc-java/issues/8984)). This allows using MinGW on Windows - xds: Unconditionally apply backoff on ADS and LDS stream recreation. Previously if a message had been received on the stream no backoff wait would be performed. This limits QPS to a buggy server to 1 QPS, instead of a closed loop - xds: Skip Routes within VirtualHosts whose RouteAction has no cluster_specifier. This probably means the control plane is using a cluster_specifier field unknown/unsupported by gRPC. The control plane can repeat the Route with a different cluster_specifier for compatibility with older clients - xds: Support `xds.config.resource-in-sotw` client capability. Resources wrapped in a `io.envoyproxy.envoy.service.discovery.v3.Resource` message are now supported ([#​8997](https://togithub.com/grpc/grpc-java/issues/8997)) ##### New Features - gcp-observability: A new experimental module for improving visibility into gRPC workloads. Initially supports logging RPCs to Google Cloud Logging - grpclb: Support setting initial fallback timeout by service config ([#​8980](https://togithub.com/grpc/grpc-java/issues/8980)) ##### Dependencies - PerfMark bumped to 0.25.0 ([#​8948](https://togithub.com/grpc/grpc-java/issues/8948)) - okhttp: the okhttp dependency is now compile only ([#​8971](https://togithub.com/grpc/grpc-java/issues/8971)). Okhttp’s internal HTTP/2 implementation was forked inside grpc-okhttp a long time ago, but there had been a few stray internal classes that had not been forked but should have been. That has now been fixed in preparation for OkHttp 3/4 support. Compile-only may cause a runtime failure for code using reflection on OkHttpChannelBuilder; add a dependency on okhttp 2.7.4 to resolve - bom: Removed protoc-gen-grpc-java from the BOM, as the classifier was confusing and it provided no value ([#​9020](https://togithub.com/grpc/grpc-java/issues/9020)) ##### Acknowledgements [@​jesseschalken](https://togithub.com/jesseschalken) [@​kluever](https://togithub.com/kluever) [@​beatrausch](https://togithub.com/beatrausch) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-common-protos).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ## [2.9.0](googleapis/java-common-protos@v2.8.3...v2.9.0) (2022-06-06) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-common-protos/issues/1440)) ([#368](googleapis/java-common-protos#368)) ([676eaf3](googleapis/java-common-protos@676eaf3)) * next release from main branch is 2.9.0 ([#354](googleapis/java-common-protos#354)) ([d0fd16b](googleapis/java-common-protos@d0fd16b)) ### Dependencies * update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#360](googleapis/java-common-protos#360)) ([741354f](googleapis/java-common-protos@741354f)) * update dependency com.google.protobuf:protobuf-bom to v3.21.0 ([#369](googleapis/java-common-protos#369)) ([dd454e3](googleapis/java-common-protos@dd454e3)) * update dependency com.google.protobuf:protobuf-bom to v3.21.1 ([#371](googleapis/java-common-protos#371)) ([25ca684](googleapis/java-common-protos@25ca684)) * update dependency com.google.protobuf:protobuf-java to v3.20.1 ([#361](googleapis/java-common-protos#361)) ([9f20508](googleapis/java-common-protos@9f20508)) * update dependency com.google.protobuf:protobuf-java to v3.21.0 ([#370](googleapis/java-common-protos#370)) ([40648c5](googleapis/java-common-protos@40648c5)) * update dependency com.google.protobuf:protobuf-java to v3.21.1 ([#372](googleapis/java-common-protos#372)) ([c54d334](googleapis/java-common-protos@c54d334)) * update dependency io.grpc:grpc-bom to v1.46.0 ([#362](googleapis/java-common-protos#362)) ([7deb7ad](googleapis/java-common-protos@7deb7ad)) * update dependency io.grpc:grpc-bom to v1.47.0 ([#373](googleapis/java-common-protos#373)) ([133b95b](googleapis/java-common-protos@133b95b)) * update dependency io.grpc:grpc-protobuf to v1.46.0 ([#363](googleapis/java-common-protos#363)) ([bfede07](googleapis/java-common-protos@bfede07)) * update dependency io.grpc:grpc-protobuf to v1.47.0 ([#374](googleapis/java-common-protos#374)) ([20baac5](googleapis/java-common-protos@20baac5)) * update dependency io.grpc:grpc-stub to v1.46.0 ([#364](googleapis/java-common-protos#364)) ([09d49b4](googleapis/java-common-protos@09d49b4)) * update dependency io.grpc:grpc-stub to v1.47.0 ([#375](googleapis/java-common-protos#375)) ([6074436](googleapis/java-common-protos@6074436)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
](https://renovatebot.com){kind=link}
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issues:
bazel run testTarget_updatedid not work when starting from a clean cache. This refactoring ensures that all the dependent targets are built when the former is run.java_binarytarget.