fix(resnames): ensure deterministic resname order for samplegen [ggj] #813

miraleung · 2021-08-03T17:59:58Z

…nto fixit/resname-flip-flop

codecov · 2021-08-03T18:10:20Z

Codecov Report

Merging #813 (1a6e4f7) into master (8c601f5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
+ Coverage   91.43%   91.46%   +0.02%     
==========================================
  Files         140      140              
  Lines       14993    15001       +8     
  Branches     1085     1085              
==========================================
+ Hits        13709    13720      +11     
+ Misses        988      986       -2     
+ Partials      296      295       -1

Impacted Files	Coverage Δ
...er/samplecode/ServiceClientSampleCodeComposer.java	`99.29% <100.00%> (+<0.01%)`	⬆️
...ic/composer/defaultvalue/DefaultValueComposer.java	`89.89% <0.00%> (+1.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c601f5...1a6e4f7. Read the comment docs.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://togithub.com/psf/requests), [changelog](https://togithub.com/psf/requests/blob/master/HISTORY.md)) | `==2.27.1` -> `==2.28.1` | [![age](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/compatibility-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/confidence-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

…813) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.19.4` -> `3.20.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.20.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.20.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.20.1/compatibility-slim/3.19.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.20.1/confidence-slim/3.19.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.20.0`](https://togithub.com/protocolbuffers/protobuf/releases/v3.20.0) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.19.4...v3.20.0) 2022-03-25 version 3.20.0 (C++/Java/Python/PHP/Objective-C/C#/Ruby/JavaScript) ##### Ruby - Dropped Ruby 2.3 and 2.4 support for CI and releases. ([#9311](https://togithub.com/protocolbuffers/protobuf/issues/9311)) - Added Ruby 3.1 support for CI and releases ([#9566](https://togithub.com/protocolbuffers/protobuf/issues/9566)). - Message.decode/encode: Add recursion_limit option ([#9218](https://togithub.com/protocolbuffers/protobuf/issues/9218)/[#9486](https://togithub.com/protocolbuffers/protobuf/issues/9486)) - Allocate with xrealloc()/xfree() so message allocation is visible to the Ruby GC. In certain tests this leads to much lower memory usage due to more frequent GC runs ([#9586](https://togithub.com/protocolbuffers/protobuf/issues/9586)). - Fix conversion of singleton classes in Ruby ([#9342](https://togithub.com/protocolbuffers/protobuf/issues/9342)) - Suppress warning for intentional circular require ([#9556](https://togithub.com/protocolbuffers/protobuf/issues/9556)) - JSON will now output shorter strings for double and float fields when possible without losing precision. - Encoding and decoding of binary format will now work properly on big-endian systems. - UTF-8 verification was fixed to properly reject surrogate code points. - Unknown enums for proto2 protos now properly implement proto2's behavior of putting such values in unknown fields. ##### Java - Revert "Standardize on Array copyOf" ([#9400](https://togithub.com/protocolbuffers/protobuf/issues/9400)) - Resolve more java field accessor name conflicts ([#8198](https://togithub.com/protocolbuffers/protobuf/issues/8198)) - Don't support map fields in DynamicMessage.Builder.{getFieldBuilder,getRepeatedFieldBuilder} - Fix parseFrom to only throw InvalidProtocolBufferException - InvalidProtocolBufferException now allows arbitrary wrapped Exception types. - Fix bug in `FieldSet.Builder.mergeFrom` - Flush CodedOutputStream also flushes underlying OutputStream - When oneof case is the same and the field type is Message, merge the subfield. (previously it was replaced.)’ - Add [@CheckReturnValue](https://togithub.com/CheckReturnValue) to some protobuf types - Report original exceptions when parsing JSON - Add more info to [@deprecated](https://togithub.com/deprecated) javadoc for set/get/has methods - Fix initialization bug in doc comment line numbers - Fix comments for message set wire format. ##### Kotlin - Add test scope to kotlin-test for protobuf-kotlin-lite ([#9518](https://togithub.com/protocolbuffers/protobuf/issues/9518)) - Add orNull extensions for optional message fields. - Add orNull extensions to all proto3 message fields. ##### Python - Dropped support for Python < 3.7 ([#9480](https://togithub.com/protocolbuffers/protobuf/issues/9480)) - Protoc is now able to generate python stubs (.pyi) with --pyi_out - Pin multibuild scripts to get manylinux1 wheels back ([#9216](https://togithub.com/protocolbuffers/protobuf/issues/9216)) - Fix type annotations of some Duration and Timestamp methods. - Repeated field containers are now generic in field types and could be used in type annotations. - Protobuf python generated codes are simplified. Descriptors and message classes' definitions are now dynamic created in internal/builder.py. Insertion Points for messages classes are discarded. - has_presence is added for FieldDescriptor in python - Loosen indexing type requirements to allow valid **index**() implementations rather than only PyLongObjects. - Fix the deepcopy bug caused by not copying message_listener. - Added python JSON parse recursion limit (default 100) - Path info is added for python JSON parse errors - Pure python repeated scalar fields will not able to pickle. Convert to list first. - Timestamp.ToDatetime() now accepts an optional tzinfo parameter. If specified, the function returns a timezone-aware datetime in the given time zone. If omitted or None, the function returns a timezone-naive UTC datetime (as previously). - Adds client_streaming and server_streaming fields to MethodDescriptor. - Add "ensure_ascii" parameter to json_format.MessageToJson. This allows smaller JSON serializations with UTF-8 or other non-ASCII encodings. - Added experimental support for directly assigning numpy scalars and array. - Improve the calculation of public_dependencies in DescriptorPool. - \[Breaking Change] Disallow setting fields to numpy singleton arrays or repeated fields to numpy multi-dimensional arrays. Numpy arrays should be indexed or flattened explicitly before assignment. ##### Compiler - Migrate IsDefault(const std::string\*) and UnsafeSetDefault(const std::string\*) - Implement strong qualified tags for TaggedPtr - Rework allocations to power-of-two byte sizes. - Migrate IsDefault(const std::string\*) and UnsafeSetDefault(const std::string\*) - Implement strong qualified tags for TaggedPtr - Make TaggedPtr Set...() calls explicitly spell out the content type. - Check for parsing error before verifying UTF8. - Enforce a maximum message nesting limit of 32 in the descriptor builder to guard against stack overflows - Fixed bugs in operators for RepeatedPtrIterator - Assert a maximum map alignment for allocated values - Fix proto1 group extension protodb parsing error - Do not log/report the same descriptor symbol multiple times if it contains more than one invalid character. - Add UnknownFieldSet::SerializeToString and SerializeToCodedStream. - Remove explicit default pointers and deprecated API from protocol compiler ##### Arenas - Change Repeated\*Field to reuse memory when using arenas. - Implements pbarenaz for profiling proto arenas - Introduce CreateString() and CreateArenaString() for cleaner semantics - Fix unreferenced parameter for MSVC builds - Add UnsafeSetAllocated to be used for one-of string fields. - Make Arena::AllocateAligned() a public function. - Determine if ArenaDtor related code generation is necessary in one place. - Implement on demand register ArenaDtor for InlinedStringField ##### C++ - Enable testing via CTest ([#8737](https://togithub.com/protocolbuffers/protobuf/issues/8737)) - Add option to use external GTest in CMake ([#8736](https://togithub.com/protocolbuffers/protobuf/issues/8736)) - CMake: Set correct sonames for libprotobuf-lite.so and libprotoc.so ([#8635](https://togithub.com/protocolbuffers/protobuf/issues/8635)) ([#9529](https://togithub.com/protocolbuffers/protobuf/issues/9529)) - Add cmake option `protobuf_INSTALL` to not install files ([#7123](https://togithub.com/protocolbuffers/protobuf/issues/7123)) - CMake: Allow custom plugin options e.g. to generate mocks ([#9105](https://togithub.com/protocolbuffers/protobuf/issues/9105)) - CMake: Use linker version scripts ([#9545](https://togithub.com/protocolbuffers/protobuf/issues/9545)) - Manually \*struct Cord fields to work better with arenas. - Manually destruct map fields. - Generate narrower code - Fix [https://github.com/protocolbuffers/protobuf/issues/9378](https://togithub.com/protocolbuffers/protobuf/issues/9378) by removing shadowed *cached_size* field - Remove GetPointer() and explicit nullptr defaults. - Add proto_h flag for speeding up large builds - Add missing overload for reference wrapped fields. - Add MergedDescriptorDatabase::FindAllFileNames() - RepeatedField now defines an iterator type instead of using a pointer. - Remove obsolete macros GOOGLE_PROTOBUF_HAS_ONEOF and GOOGLE_PROTOBUF_HAS_ARENAS. ##### PHP - Fix: add missing reserved classnames ([#9458](https://togithub.com/protocolbuffers/protobuf/issues/9458)) - PHP 8.1 compatibility ([#9370](https://togithub.com/protocolbuffers/protobuf/issues/9370)) ##### C\# - Fix trim warnings ([#9182](https://togithub.com/protocolbuffers/protobuf/issues/9182)) - Fixes NullReferenceException when accessing FieldDescriptor.IsPacked ([#9430](https://togithub.com/protocolbuffers/protobuf/issues/9430)) - Add ToProto() method to all descriptor classes ([#9426](https://togithub.com/protocolbuffers/protobuf/issues/9426)) - Add an option to preserve proto names in JsonFormatter ([#6307](https://togithub.com/protocolbuffers/protobuf/issues/6307)) ##### Objective-C - Add prefix_to_proto_package_mappings_path option. ([#9498](https://togithub.com/protocolbuffers/protobuf/issues/9498)) - Rename `proto_package_to_prefix_mappings_path` to `package_to_prefix_mappings_path`. ([#9552](https://togithub.com/protocolbuffers/protobuf/issues/9552)) - Add a generation option to control use of forward declarations in headers. ([#9568](https://togithub.com/protocolbuffers/protobuf/issues/9568)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18) ### Features * **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a)) * next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212)) ### Bug Fixes * remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee)) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09)) * update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db)) * update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d)) * update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db)) * update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c)) * update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567)) * update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17)) * update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1)) * update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41)) * update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507)) * update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

miraleung added 2 commits July 27, 2021 21:55

fix(resnames): ensure deterministic resname order for samplegen

d16855e

Merge branch 'master' of github.com:googleapis/gapic-generator-java i…

6c1a4f1

…nto fixit/resname-flip-flop

miraleung requested a review from a team as a code owner August 3, 2021 17:59

product-auto-label bot added the samples Issues that are directly related to samples. label Aug 3, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2021

miraleung requested a review from vam-google August 3, 2021 18:00

miraleung requested review from Neenu1995 and chingor13 August 4, 2021 19:48

Neenu1995 approved these changes Aug 4, 2021

View reviewed changes

Merge branch 'master' into dev/resname-flip-flop

1a6e4f7

miraleung merged commit c4709df into master Aug 5, 2021

miraleung deleted the dev/resname-flip-flop branch August 5, 2021 19:11

chingor13 mentioned this pull request Sep 27, 2021

resource names are flip-flopping in generated test code #847

Closed

chanseokoh mentioned this pull request Oct 27, 2021

fix(resnames): ensure determinstic code generation #865

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(resnames): ensure deterministic resname order for samplegen [ggj] #813

fix(resnames): ensure deterministic resname order for samplegen [ggj] #813

miraleung commented Aug 3, 2021

codecov bot commented Aug 3, 2021 •

edited

Loading

fix(resnames): ensure deterministic resname order for samplegen [ggj] #813

fix(resnames): ensure deterministic resname order for samplegen [ggj] #813

Conversation

miraleung commented Aug 3, 2021

codecov bot commented Aug 3, 2021 • edited Loading

Codecov Report

codecov bot commented Aug 3, 2021 •

edited

Loading