feat!: Support Node 18+ (#2011)

* feat!: Support Node 18+ * chore: Additional Node 18 upgrades * chore: don't change test fixtures * feat: Move kokoro directories to 18 * chore: Update checkout and setup-node to v4 - https://github.com/actions/checkout/releases/tag/v4.0.0 - https://github.com/actions/setup-node/releases/tag/v4.0.0
googleapis · Oct 4, 2024 · c19dd80 · c19dd80
1 parent 38fa49f
commit c19dd80
Show file tree

Hide file tree

Showing 20 changed files with 24 additions and 24 deletions.
diff --git a/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml b/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml
@@ -9,10 +9,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}, {{metadata['engine'] | int+6}}]
+        node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}}]
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ '{{' }} matrix.node {{ '}}' }}
       - run: node --version
@@ -29,30 +29,30 @@ jobs:
   windows:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install --engine-strict
       - run: npm test
         env:
           MOCHA_THROW_DEPRECATION: false
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run lint
   docs:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run docs
       - uses: JustinBeckwith/linkinator-action@v1

diff --git a/synthtool/gcp/templates/node_library/.kokoro/common.cfg b/synthtool/gcp/templates/node_library/.kokoro/common.cfg
diff --git a/...rary/.kokoro/continuous/node14/common.cfg → ...rary/.kokoro/continuous/node18/common.cfg b/...rary/.kokoro/continuous/node14/common.cfg → ...rary/.kokoro/continuous/node18/common.cfg
diff --git a/...ibrary/.kokoro/continuous/node14/lint.cfg → ...ibrary/.kokoro/continuous/node18/lint.cfg b/...ibrary/.kokoro/continuous/node14/lint.cfg → ...ibrary/.kokoro/continuous/node18/lint.cfg
diff --git a/...kokoro/continuous/node14/samples-test.cfg → ...kokoro/continuous/node18/samples-test.cfg b/...kokoro/continuous/node14/samples-test.cfg → ...kokoro/continuous/node18/samples-test.cfg
diff --git a/....kokoro/continuous/node14/system-test.cfg → ....kokoro/continuous/node18/system-test.cfg b/....kokoro/continuous/node14/system-test.cfg → ....kokoro/continuous/node18/system-test.cfg
diff --git a/...ibrary/.kokoro/continuous/node14/test.cfg → ...ibrary/.kokoro/continuous/node18/test.cfg b/...ibrary/.kokoro/continuous/node14/test.cfg → ...ibrary/.kokoro/continuous/node18/test.cfg
diff --git a/...brary/.kokoro/presubmit/node14/common.cfg → ...brary/.kokoro/presubmit/node18/common.cfg b/...brary/.kokoro/presubmit/node14/common.cfg → ...brary/.kokoro/presubmit/node18/common.cfg
diff --git a/....kokoro/presubmit/node14/samples-test.cfg → ....kokoro/presubmit/node18/samples-test.cfg b/....kokoro/presubmit/node14/samples-test.cfg → ....kokoro/presubmit/node18/samples-test.cfg
diff --git a/.../.kokoro/presubmit/node14/system-test.cfg → .../.kokoro/presubmit/node18/system-test.cfg b/.../.kokoro/presubmit/node14/system-test.cfg → .../.kokoro/presubmit/node18/system-test.cfg
diff --git a/...library/.kokoro/presubmit/node14/test.cfg → ...library/.kokoro/presubmit/node18/test.cfg b/...library/.kokoro/presubmit/node14/test.cfg → ...library/.kokoro/presubmit/node18/test.cfg
diff --git a/synthtool/gcp/templates/node_library/.kokoro/release/docs-devsite.cfg b/synthtool/gcp/templates/node_library/.kokoro/release/docs-devsite.cfg
diff --git a/synthtool/gcp/templates/node_library/.kokoro/release/docs.cfg b/synthtool/gcp/templates/node_library/.kokoro/release/docs.cfg
diff --git a/synthtool/gcp/templates/node_library/.kokoro/release/docs.sh b/synthtool/gcp/templates/node_library/.kokoro/release/docs.sh
diff --git a/synthtool/gcp/templates/node_library/.kokoro/release/publish.cfg b/synthtool/gcp/templates/node_library/.kokoro/release/publish.cfg
diff --git a/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh b/synthtool/gcp/templates/node_library/.kokoro/samples-test.sh
diff --git a/synthtool/gcp/templates/node_library/.kokoro/system-test.sh b/synthtool/gcp/templates/node_library/.kokoro/system-test.sh
diff --git a/synthtool/gcp/templates/node_library/.kokoro/test.bat b/synthtool/gcp/templates/node_library/.kokoro/test.bat
diff --git a/synthtool/gcp/templates/node_library/.kokoro/test.sh b/synthtool/gcp/templates/node_library/.kokoro/test.sh
diff --git a/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh b/synthtool/gcp/templates/node_library/.kokoro/trampoline_v2.sh