Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): simplify nox steps in CONTRIBUTING.rst #1135

Merged
merged 3 commits into from
Jun 25, 2021
Merged

chore(python): simplify nox steps in CONTRIBUTING.rst #1135

merged 3 commits into from
Jun 25, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 22, 2021

This is a follow up to PR #1132 based on feedback from googleapis/python-bigquery-sqlalchemy#191 to simplify the steps to run nox in CONTRIBUTING.rst.

@parthea parthea requested a review from a team as a code owner June 22, 2021 19:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 22, 2021
@parthea parthea changed the title chore: simplify nox steps in CONTRIBUTING.rst chore(python): simplify nox steps in CONTRIBUTING.rst Jun 22, 2021
@parthea parthea mentioned this pull request Jun 22, 2021
Closed
@busunkim96
Copy link
Contributor

Is it worth capturing in the doc that you can select a single unit test version with nox -s unit-3.6? Or is that level of detail not desired?

@jimfulton
Copy link

jimfulton commented Jun 22, 2021 •
edited
Loading

I think it's worthwhile to show a single unit-test version example, as we do for system tests.

@parthea
Copy link
Contributor Author

parthea commented Jun 22, 2021

@busunkim96 @jimfulton I've simplified the instructions. PTAL.

@parthea
Copy link
Contributor Author

parthea commented Jun 23, 2021 •
edited
Loading

Wait for #1137 to be merged first as the body of this PR contains a relative link which won't work in downstream repos.

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 23, 2021
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 25, 2021
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 26558ba into master Jun 25, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the clean-up-contributing.rst branch June 25, 2021 15:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthea @busunkim96 @jimfulton @SurferJeffAtGoogle