Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): add .github/CODEOWNERS as a templated file #1201

Merged
merged 8 commits into from
Nov 11, 2021
Merged

chore(python): add .github/CODEOWNERS as a templated file #1201

merged 8 commits into from
Nov 11, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 2, 2021 •
edited
Loading

I tested these changes by running the following commands after cloning synthtool

git checkout template-codeowners
docker build -t testcodeowners -f docker/owlbot/python/Dockerfile .

Once the docker image was built, I ran the following command in the root of python-contact-center-insights

docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo template-codeowners

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2021
@parthea parthea mentioned this pull request Sep 3, 2021
Closed
@parthea parthea marked this pull request as ready for review September 3, 2021 10:07
@parthea parthea requested a review from a team as a code owner September 3, 2021 10:07
@parthea parthea changed the title [WIP] chore(python): add .github/CODEOWNERS as a templated file chore(python): add .github/CODEOWNERS as a templated file Sep 3, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2021
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2021
@parthea parthea mentioned this pull request Sep 3, 2021
Closed
This was referenced Sep 3, 2021
Merged
Merged
Merged
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 3, 2021
@parthea parthea mentioned this pull request Sep 3, 2021
Merged
@tseaver
Copy link
Contributor

tseaver commented Sep 3, 2021

@parthea Please do not merge this until checking that all "manual" libraries exclude .github/CODEOWNERS in their owlbot.py: this PR would have negative impact on them, and make the discoverability / ease-of-customization for those repose unnecessarily harder.

@parthea
Copy link
Contributor Author

parthea commented Sep 3, 2021

@tseaver , I agree. I've added this as a requirement.

@busunkim96
Copy link
Contributor

Was the check for GAPIC_AUTO removed intentionally?

@tseaver
Copy link
Contributor

tseaver commented Sep 3, 2021

@busunkim96

Was the check for GAPIC_AUTO removed intentionally?

I think we need to exclude .github/CODEOWNERS from being copied altogeher for the manual repos. They have local policies which no amount of templating / s.replace-ing will not be worse than just excluding.

@parthea
Copy link
Contributor Author

parthea commented Sep 27, 2021

Capturing comment from googleapis/python-data-qna#83 to be incorporated in this PR:

Could the synthtool template for CODEOWNERS note that the file is generated and that edits should be made to .repo-metadata.json?

tseaver added a commit to googleapis/python-datastore that referenced this pull request Sep 27, 2021
@tseaver
chore: exclude 'CODEOWNERS' from templated files
9b1cbd5 
See: googleapis/synthtool#1201
@tseaver tseaver mentioned this pull request Sep 27, 2021
Merged
tseaver added a commit to googleapis/python-firestore that referenced this pull request Sep 27, 2021
@tseaver
chore: exclude 'CODEOWNERS' from templated files
72f6e13 
See: googleapis/synthtool#1201
@tseaver tseaver mentioned this pull request Sep 27, 2021
Merged
@parthea parthea self-assigned this Nov 11, 2021
This was referenced Nov 11, 2021
Merged
Merged
Merged
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2021
@parthea parthea assigned busunkim96 and tswast and unassigned parthea Nov 11, 2021
@parthea
Copy link
Contributor Author

parthea commented Nov 11, 2021

@busunkim96 @tswast @tseaver This is ready for review

@parthea parthea merged commit c5026b3 into master Nov 11, 2021
@parthea parthea deleted the template-codeowners branch November 11, 2021 16:23
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@tseaver @abdelmegahedgoogle
chore: exclude 'CODEOWNERS' from templated files (googleapis#986)
002ba3b 
See: googleapis/synthtool#1201
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@parthea @abdelmegahedgoogle
chore: add default_version and codeowner_team to .repo-metadata.json (g…
383be7b 
…oogleapis#1001)

Set codeowner_team to googleapis/api-bigquery as codeowner. Set default_version to v2. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
b3381ba 
…33)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
d5b0561 
…29)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
22f0759 
…47)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
c99960f 
…116)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
2690d27 
…92)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
de0fcb1 
…118)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
vchudnov-g pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
4a4370e 
…411)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
@parthea
chore: add default_version and codeowner_team to .repo-metadata.json (#…
d5bcf22 
…267)

By default the code owner will be googleapis/yoshi-python. This change is needed for the following synthtool PRs.

googleapis/synthtool#1201
googleapis/synthtool#1114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees

@tseaver tseaver

@tswast tswast

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parthea @tseaver @busunkim96 @tswast @kokoro-team