Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): use black==22.3.0 #1376

Merged
merged 1 commit into from
Mar 28, 2022
Merged

chore(python): use black==22.3.0 #1376

merged 1 commit into from
Mar 28, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 28, 2022

Fixes #1375

@parthea parthea requested a review from a team as a code owner March 28, 2022 23:02
dandhlee
dandhlee reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin click version instead of updating black?

@busunkim96
Copy link
Contributor

The current version of black is fairly old (October 2019), so I'm in favor of bumping to 22.3.0.

dandhlee
dandhlee approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@parthea parthea merged commit 6fab84a into master Mar 28, 2022
@parthea parthea deleted the upgrade-black branch March 28, 2022 23:20
@parthea parthea mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(python): upgrade black to 22.3.0
3 participants
@parthea @busunkim96 @dandhlee