Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update test-samples-impl.sh python3.6 --> python3.9 #1476

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Jun 30, 2022

Upgrade from python3.6 --> python3.10 in the docker image (gcr.io/cloud-devrel-kokoro-resources/python-samples-testing-docker) necessitates a consistent upgrade in the samples runners:

https://github.com/GoogleCloudPlatform/python-docs-samples/pull/8135/files

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 30, 2022
@nicain nicain changed the title Update test-samples-impl.sh python3.6 --> python3.10 fix: Update test-samples-impl.sh python3.6 --> python3.10 Jun 30, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@nicain nicain marked this pull request as ready for review June 30, 2022 23:33
@nicain nicain requested a review from a team as a code owner June 30, 2022 23:33
@nicain nicain requested a review from parthea June 30, 2022 23:34
@ivanmkc
Copy link

ivanmkc commented Jul 1, 2022

@nicain we will likely downgrade to 3.9. See GoogleCloudPlatform/python-docs-samples#8146

@nicain nicain changed the title fix: Update test-samples-impl.sh python3.6 --> python3.10 fix: Update test-samples-impl.sh python3.6 --> python3.9 Jul 1, 2022
@m-strzelczyk m-strzelczyk merged commit 1f07110 into master Jul 4, 2022
@m-strzelczyk m-strzelczyk deleted the nicain-patch-1 branch July 4, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants