-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [autoapprove] Update black
and isort
to latest versions
#1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtskinner
added a commit
to GoogleCloudPlatform/python-docs-samples
that referenced
this pull request
Jun 13, 2023
- Temporary until googleapis/synthtool#1811 is added to synthtool
holtskinner
changed the title
fix: Add Google Profile to
fix: Update Jun 26, 2023
isort
format
sessionblack
and isort
to latest versions
holtskinner
force-pushed
the
noxfile-update
branch
4 times, most recently
from
June 28, 2023 15:16
6d043c1
to
3fc00aa
Compare
holtskinner
requested review from
SurferJeffAtGoogle,
chingor13,
bcoe and
a team
as code owners
June 28, 2023 15:16
parthea
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added observations
holtskinner
force-pushed
the
noxfile-update
branch
2 times, most recently
from
August 1, 2023 18:21
8e2d330
to
d69aa4a
Compare
holtskinner
force-pushed
the
noxfile-update
branch
2 times, most recently
from
August 1, 2023 18:24
d69aa4a
to
0ddbff8
Compare
- Add `black[jupyter]` because several samples directories include jupyter notebooks - Add type hinting to avoid lint errors/warnings
Cleaned up commit history, and addressed comments. |
parthea
changed the title
fix: Update
chore: [autoapprove] Update Oct 9, 2023
black
and isort
to latest versionsblack
and isort
to latest versions
parthea
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort
format
sessionblack[jupyter]
because several samples directories include jupyter notebooks