Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [autoapprove] Update black and isort to latest versions #1811

Merged
merged 8 commits into from
Oct 9, 2023

Conversation

holtskinner
Copy link
Member

@holtskinner holtskinner commented Jun 13, 2023

  • Add Google Profile to isort format session
  • Add black[jupyter] because several samples directories include jupyter notebooks

@holtskinner holtskinner requested a review from a team as a code owner June 13, 2023 14:52
holtskinner added a commit to GoogleCloudPlatform/python-docs-samples that referenced this pull request Jun 13, 2023
@holtskinner holtskinner changed the title fix: Add Google Profile to isort format session fix: Update black and isort to latest versions Jun 26, 2023
@holtskinner holtskinner force-pushed the noxfile-update branch 4 times, most recently from 6d043c1 to 3fc00aa Compare June 28, 2023 15:16
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added observations

synthtool/gcp/templates/python_library/noxfile.py.j2 Outdated Show resolved Hide resolved
synthtool/gcp/templates/python_library/noxfile.py.j2 Outdated Show resolved Hide resolved
@parthea parthea assigned holtskinner and unassigned parthea Aug 1, 2023
@holtskinner holtskinner force-pushed the noxfile-update branch 2 times, most recently from 8e2d330 to d69aa4a Compare August 1, 2023 18:21
@holtskinner holtskinner requested review from a team as code owners August 1, 2023 18:21
@holtskinner holtskinner closed this Aug 1, 2023
@holtskinner holtskinner force-pushed the noxfile-update branch 2 times, most recently from d69aa4a to 0ddbff8 Compare August 1, 2023 18:24
- Add `black[jupyter]` because several samples directories include jupyter notebooks
- Add type hinting to avoid lint errors/warnings
@holtskinner holtskinner reopened this Aug 1, 2023
@holtskinner
Copy link
Member Author

holtskinner commented Aug 1, 2023

Cleaned up commit history, and addressed comments.

@holtskinner holtskinner removed their assignment Aug 1, 2023
@parthea parthea self-assigned this Aug 1, 2023
@parthea parthea removed their assignment Sep 8, 2023
@parthea parthea changed the title fix: Update black and isort to latest versions chore: [autoapprove] Update black and isort to latest versions Oct 9, 2023
@parthea parthea enabled auto-merge (squash) October 9, 2023 13:54
@parthea parthea assigned parthea and unassigned SurferJeffAtGoogle Oct 9, 2023
@parthea parthea merged commit 0c7b033 into googleapis:master Oct 9, 2023
7 checks passed
@holtskinner holtskinner deleted the noxfile-update branch January 8, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants