feat!: Support Node 18+

synthtool/gcp/templates/node_library/.github/workflows/ci.yaml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}, {{metadata['engine'] | int+6}}]
+        node: [{{metadata['engine'] | int}}, {{metadata['engine'] | int+2}}, {{metadata['engine'] | int+4}}}]
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
@@ -32,7 +32,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install --engine-strict
       - run: npm test
         env:
@@ -43,7 +43,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run lint
   docs:
@@ -52,7 +52,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 14
+          node-version: 18
       - run: npm install
       - run: npm run docs
       - uses: JustinBeckwith/linkinator-action@v1

tests/fixtures/node_templates/no_version/package.json

@@ -4,7 +4,7 @@
   "license": "Apache-2.0",
   "repository": "googleapis/repo-automation-bots",
   "engines": {
-    "node": ">=12.0.0"
+    "node": ">=18"
   },
   "scripts": {
     "run": "./scripts/scripts.js",

tests/fixtures/node_templates/package_json_mono_repo/package.json

@@ -1,77 +1,77 @@
 {
-    "name": "@google-cloud/dlp",
-    "description": "DLP API client for Node.js",
-    "version": "3.1.0",
-    "license": "Apache-2.0",
-    "author": "Google Inc",
-    "engines": {
-      "node": ">=10.0.0"
-    },
-    "repository": {
-      "type": "git",
-      "url": "https://github.com/googleapis/google-cloud-node.git",
-      "directory": "packages/google-cloud-dlp"
-    },
-    "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-dlp",
-    "main": "build/src/index.js",
-    "files": [
-      "build/protos",
-      "build/src"
-    ],
-    "keywords": [
-      "google apis client",
-      "google api client",
-      "google apis",
-      "google api",
-      "google",
-      "google cloud platform",
-      "google cloud",
-      "cloud",
-      "google dlp",
-      "dlp",
-      "DLP API"
-    ],
-    "scripts": {
-      "test": "c8 mocha build/test",
-      "samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
-      "system-test": "mocha build/system-test",
-      "docs": "jsdoc -c .jsdoc.js",
-      "lint": "gts check",
-      "fix": "gts fix",
-      "docs-test": "linkinator docs",
-      "clean": "gts clean",
-      "compile": "tsc -p . && cp -r protos build/",
-      "compile-protos": "compileProtos src",
-      "predocs-test": "npm run docs",
-      "prepare": "npm run compile-protos && npm run compile",
-      "prelint": "cd samples; npm link ../; npm install",
-      "precompile": "gts clean",
-      "api-extractor": "api-extractor run --local",
-      "api-documenter": "api-documenter yaml --input-folder=temp"
-    },
-    "dependencies": {
-      "google-gax": "^2.9.2",
-      "protobufjs": "^6.8.0"
-    },
-    "devDependencies": {
-      "@types/mocha": "^8.0.0",
-      "@types/node": "^12.0.0",
-      "@types/sinon": "^9.0.0",
-      "c8": "^7.0.0",
-      "gts": "^2.0.0",
-      "jsdoc": "^3.5.5",
-      "jsdoc-fresh": "^1.0.1",
-      "jsdoc-region-tag": "^1.0.2",
-      "linkinator": "^2.0.0",
-      "mocha": "^8.0.0",
-      "null-loader": "^4.0.0",
-      "pack-n-play": "^1.0.0-2",
-      "sinon": "^14.0.0",
-      "ts-loader": "^9.0.0",
-      "typescript": "^3.8.3",
-      "webpack": "^5.0.0",
-      "webpack-cli": "^4.0.0",
-      "@microsoft/api-documenter": "^7.8.10",
-      "@microsoft/api-extractor": "^7.8.10"
-    }
-  }
+  "name": "@google-cloud/dlp",
+  "description": "DLP API client for Node.js",
+  "version": "3.1.0",
+  "license": "Apache-2.0",
+  "author": "Google Inc",
+  "engines": {
+    "node": ">=18"
+  },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/googleapis/google-cloud-node.git",
+    "directory": "packages/google-cloud-dlp"
+  },
+  "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/packages/google-cloud-dlp",
+  "main": "build/src/index.js",
+  "files": [
+    "build/protos",
+    "build/src"
+  ],
+  "keywords": [
+    "google apis client",
+    "google api client",
+    "google apis",
+    "google api",
+    "google",
+    "google cloud platform",
+    "google cloud",
+    "cloud",
+    "google dlp",
+    "dlp",
+    "DLP API"
+  ],
+  "scripts": {
+    "test": "c8 mocha build/test",
+    "samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
+    "system-test": "mocha build/system-test",
+    "docs": "jsdoc -c .jsdoc.js",
+    "lint": "gts check",
+    "fix": "gts fix",
+    "docs-test": "linkinator docs",
+    "clean": "gts clean",
+    "compile": "tsc -p . && cp -r protos build/",
+    "compile-protos": "compileProtos src",
+    "predocs-test": "npm run docs",
+    "prepare": "npm run compile-protos && npm run compile",
+    "prelint": "cd samples; npm link ../; npm install",
+    "precompile": "gts clean",
+    "api-extractor": "api-extractor run --local",
+    "api-documenter": "api-documenter yaml --input-folder=temp"
+  },
+  "dependencies": {
+    "google-gax": "^2.9.2",
+    "protobufjs": "^6.8.0"
+  },
+  "devDependencies": {
+    "@types/mocha": "^8.0.0",
+    "@types/node": "^18.19.50",
+    "@types/sinon": "^9.0.0",
+    "c8": "^7.0.0",
+    "gts": "^2.0.0",
+    "jsdoc": "^3.5.5",
+    "jsdoc-fresh": "^1.0.1",
+    "jsdoc-region-tag": "^1.0.2",
+    "linkinator": "^2.0.0",
+    "mocha": "^8.0.0",
+    "null-loader": "^4.0.0",
+    "pack-n-play": "^1.0.0-2",
+    "sinon": "^14.0.0",
+    "ts-loader": "^9.0.0",
+    "typescript": "^3.8.3",
+    "webpack": "^5.0.0",
+    "webpack-cli": "^4.0.0",
+    "@microsoft/api-documenter": "^7.8.10",
+    "@microsoft/api-extractor": "^7.8.10"
+  }
+}