fix: make args optional #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
alexander-fenster
approved these changes
May 4, 2020
There was a problem hiding this comment.
LGTM but I'd like someone with Python background to take a look (@SurferJeffAtGoogle? :) )
bcoe
reviewed
May 4, 2020
| @@ -94,7 +94,7 @@ def node_library(self, **kwargs) -> Path: | |||
| kwargs["publish_token"] = node.get_publish_token(kwargs["metadata"]["name"]) | |||
|
|
|||
| # generate root-level `src/index.ts` to export multiple versions and its default clients | |||
| if kwargs["versions"] and kwargs["default_version"]: | |||
| if "versions" in kwargs and "default_version" in kwargs: | |||
There was a problem hiding this comment.
echoing @alexander-fenster's comment, I'm not the best Python developer these days. This looks good to me, but could we add a test to confirm the behavior perhaps?
bcoe
approved these changes
May 5, 2020
There was a problem hiding this comment.
I understand if it's too much of a hassle to add a test to common, since we don't have a pattern for testing this yet.
I'll leave it up to you (depending on @SurferJeffAtGoogle's feedback).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple version needs two args:
versionsanddefualt_version:it should be the optional arguments, but previous code throw
keyError