build(test): recursively find test files; fail on unsupported dependency versions #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve been the case in the past
google-cla
bot
added
the
cla: yes
alexander-fenster
approved these changes
Aug 18, 2020
fhinkel
approved these changes
Sep 10, 2020
bcoe
changed the title
bcoe
added
the
do not merge
|
Having a discussion with @feywind about perhaps also updating our |
product-auto-label
bot
added
the
api: cloudbuild
feywind
requested review from
bcoe,
chingor13 and
SurferJeffAtGoogle
as code owners
bcoe
approved these changes
Sep 12, 2020
bcoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... it seems to have been the case in the past.
We discovered that a big swath of tests weren't being run in the nodejs-pubsub library because they're in a subtree. This would enable recursion explicitly in the Mocha config file. I have to believe that we once did this, because the tests were there.