Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(java): auto-approve README regeneration #789

Merged
merged 6 commits into from
Oct 15, 2020
Merged

build(java): auto-approve README regeneration #789

merged 6 commits into from
Oct 15, 2020

Conversation

chingor13
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 7, 2020
@chingor13
Copy link
Contributor Author

This is blocked by #788

@chingor13 chingor13 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2020
@chingor13 chingor13 closed this Oct 12, 2020
@chingor13 chingor13 reopened this Oct 12, 2020
@chingor13 chingor13 requested a review from a team October 12, 2020 21:45
@chingor13
Copy link
Contributor Author

This has been tested for about a week in https://github.com/googleapis/java-asset/blob/master/.github/workflows/approve-readme.yaml

@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7c53709 into googleapis:master Oct 15, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2020
@chingor13 chingor13 deleted the java-automerge-readme branch October 15, 2020 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chingor13 @stephaniewang526 @SurferJeffAtGoogle