chore: fix Node.js TOC for cloud-rad #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
SurferJeffAtGoogle
approved these changes
Oct 21, 2020
|
I think this will result in 100 PRs without context tomorrow morning, due to landing this on the same day. @SurferJeffAtGoogle any advice to make this less of a pain? |
|
They'll have context, but because there will be two commits in the PR, the
PR title will be "Changes due to synthtool," yadayada.
If you'd like to avoid that, visit fusion and trigger all 10 nodejs shards
to rebuild. Merge the generated PRs, then merge this PR.
…On Wed, Oct 21, 2020 at 7:45 AM Benjamin E. Coe ***@***.***> wrote:
I think this will result in 100 PRs without context tomorrow morning, due
to landing this
<f96d3b4>
on the same day.
@SurferJeffAtGoogle <https://github.com/SurferJeffAtGoogle> any advice to
make this less of a pain?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ3TYRE5MKMVLY22IMQYZ3SL3XZLANCNFSM4SZ4ATVA>
.
|
|
Or we can wait a few days before we merge this? Sorry for the confusion. Of course I don't get a |
|
@SurferJeffAtGoogle @fhinkel why don't we just make sure at the end of the day today, that there are no PRs open with the title "Changes due to synthtool". Then we can merge this, and tomorrow morning rename all the PRs? |
|
That's fine too. But clicking all the jobs in fusion is pretty easy: 2
clicks for each shard, and it's done. And it's no different from a nightly
run.
…On Wed, Oct 21, 2020 at 8:03 AM Benjamin E. Coe ***@***.***> wrote:
@SurferJeffAtGoogle <https://github.com/SurferJeffAtGoogle> @fhinkel
<https://github.com/fhinkel> why don't we just make sure at the end of
the day today, that there are no PRs open with the title "Changes due to
synthtool".
Then we can merge this, and tomorrow morning rename all the PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACZ3TYT2UAYVNKF5COXZGWTSL3Z3PANCNFSM4SZ4ATVA>
.
|
JustinBeckwith
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.