Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

fix typos #2038

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix typos #2038

wants to merge 2 commits into from

Conversation

Birdi7
Copy link

@Birdi7 Birdi7 commented Oct 18, 2019

Hello. I fixed 2 typos in README's

Fixed typo in third_party/java/jetty/README.md
Fix typo in third_party/java/json_simple/README.txt
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Birdi7
Copy link
Author

Birdi7 commented Oct 18, 2019

@googlebot I signed it!

@kpreid
Copy link
Contributor

kpreid commented Oct 21, 2019

Sorry, I couldn't find a CLA on file under your GitHub username. Please make sure you've signed the CLA and that your commits are edited to have your matching email address (right now they are [email protected], which I believe is the default for users without a public email address).

@Birdi7
Copy link
Author

Birdi7 commented Oct 26, 2019

@kpreid But I signed it with email [email protected] marked Birdi7 as my Github username. The commits are signed with [email protected] also

@kpreid
Copy link
Contributor

kpreid commented Oct 26, 2019

The commit author email address in your two commits is still [email protected]. The easiest way to fix this — assuming you're using GitHub's web interface — is to make the same edits again, in a different branch than patch-1. Before you do this, make sure the "Keep my email addresses private" option in GitHub's preferences is off.

(On the command line, a rebase -i where you edit each commit by git commit --amend --reset-author and make no other changes would do it, assuming you've set your email address. But I would not recommend doing this if you're not familiar with performing interactive rebases.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants