This repository has been archived by the owner on Apr 25, 2018. It is now read-only.
Remove nodejs requirement for host machine #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silent failures generated a lot of issues, so I moved the node and npm stuff to the web containers. The files are now just copied to the web container instead of being mounted as a volume, which means that some changes are needed for active development (which requires nodejs on the host machine). Will update instructions if people ask for it.
|
@kroikie @ToddKerpelman (and anyone that wants to comment!) this avoids "silent failures" caused by problems with nodejs and its toolchain on the host machine, and avoid the need having nodejs etc. on the host machine. WDYT? |
|
I can't say I completely understand the impact of the changes you made, but I like fewer silent failures... |
|
Is to fix issues like #18 (comment): with this change the frontend requirements are all in the docker image, so "it should just work"™every time. |
This was referenced Mar 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silent failures generated a lot of issues, so I moved the node and npm
stuff to the web containers. The files are now just copied to the web container
instead of being mounted as a volume, which means that some changes are needed
for active development (which requires nodejs on the host machine).
Will update instructions if people ask for it.