Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(non native url): fail test when url is not a native implementation #5748

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

wardpeet
Copy link
Collaborator

@wardpeet wardpeet commented Jul 28, 2018

Summary

Bugfix: fixes websites overriding URL variable with something custom
When running node lighthouse-cli/index.js https://www.dailyo.in -G --verbose --devtools.throttling=provided you get the following output:

Sat, 28 Jul 2018 11:14:27 GMT method <= browser OK:verbose Runtime.evaluate {"result":{"type":"object","value":[{"err":{"message":"URL is not a constructor","stack":"TypeError: URL is not a constructor\n    at matches.forE
Sat, 28 Jul 2018 11:14:27 GMT method <= browser OK:verbose Runtime.evaluate {"result":{"type":"object","value":[{"err":{"message":"URL is not a constructor","stack":"TypeError: URL is not a constructor\n    at matches.forE

Related Issues/PRs

#5701

@devtools-bot
Copy link

Thanks chief! Appreciate you filing this bug. 👏

This is a known issue, most well described in #2784. So, we'll automatically close this as a duplicate.

However, if you believe your bug is different than the cases described there, please comment here with "necessarily-wide-alpaca" and I'll reopen this bug. 🤖 Beep beep boop.

@wardpeet
Copy link
Collaborator Author

necessarily-wide-alpaca

@wardpeet wardpeet reopened this Jul 28, 2018
@wardpeet wardpeet requested a review from paulirish as a code owner July 28, 2018 11:16
@paulirish
Copy link
Member

Thanks. This fixes a pretty huge sentry bug. https://sentry.io/google-lighthouse/lighthouse/issues/495524891/?environment=production

@paulirish paulirish merged commit b5f0e62 into master Jul 30, 2018
@paulirish paulirish deleted the bug/native-url branch July 30, 2018 22:39
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants