Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(pwa): audit and report group renames #6494

Merged
merged 1 commit into from
Nov 6, 2018
Merged

core(pwa): audit and report group renames #6494

merged 1 commit into from
Nov 6, 2018

Conversation

brendankenny
Copy link
Member

Requested renames from #6395

  • Going with "PWA Optimized" for the third group for now (see ongoing discussion in PWA category refactor tracking issue #6395 (comment))
  • Updated "Address bar matches brand colors" to "Sets an address-bar theme color"
  • Updated "Responds with a 200 when offline" to "Current page does not respond with a 200 when offline"

These are the replacements previously discussed. Note that we can keep tweaking after this, this just gets us to the state of the doc.

@brendankenny brendankenny merged commit 2f43eb9 into master Nov 6, 2018
@brendankenny brendankenny deleted the pwarenames branch November 6, 2018 22:32
@brendankenny brendankenny mentioned this pull request Nov 6, 2018
Closed
31 tasks
brendankenny added a commit that referenced this pull request Nov 6, 2018
@brendankenny
update for #6494
ed2d9ea
@brendankenny brendankenny mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@exterkamp exterkamp Awaiting requested review from exterkamp

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendankenny @paulirish