report(redesign): design review feedback #8785
Conversation
| anchorElement.addEventListener('click', e => { | ||
| e.preventDefault(); | ||
| window.history.pushState({}, '', anchorElement.hash); | ||
| this._dom.find(anchorElement.hash, this._document).scrollIntoView({behavior: 'smooth'}); |
There was a problem hiding this comment.
was mentioned in the design meeting. @yuinchien asked if the animation could be shorter. i said what if it were just removed completely. i thought everyone said ok
idea was just - user wants to see a particular part of the report, so just show them as soon as intent is made w/o the fanfare of a scroll animation.
There was a problem hiding this comment.
yuin and i are still attached to it. i got a branch for fixing the highlighter anim
There was a problem hiding this comment.
@paulirish whats up with this
This reverts commit 9b7b890.
This reverts commit ef75423.
| } | ||
|
|
||
| .lh-table thead { | ||
| background-color: var(--lh-table-higlight-bg); | ||
| } | ||
| .lh-table thead th { |
There was a problem hiding this comment.
we had something in there about text alignment with headers
- getting description flush left with the title.
- getting URL flush left with those two.
right, @yuinchien?
There was a problem hiding this comment.
hm i aligned it to the description instead
There was a problem hiding this comment.
@hoten the title, description, the table heading(URL), the table should all align left to the same line.
There was a problem hiding this comment.
@hoten can we horizontally center the shape (triangle) with the first line of title? Thanks!
|
todo |
|
oops. one more piece on the alignment it seems:
the left padding on the th:first-child should be 0 to get "URL" flush with the rest. |
|
#8185
See feedback under "Round two": https://docs.google.com/document/d/15L5iaWo4ieouegpSlaqGGWpA13JnTv73xnpxuVhzkBg/edit
See commit descriptions for whats up in this PR