[crater] Use logging for ci

googlefonts · Sep 17, 2024 · 177bee8 · 177bee8
1 parent 218f877
commit 177bee8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/fontc_crater/Cargo.toml b/fontc_crater/Cargo.toml
@@ -10,7 +10,7 @@ readme = "README.md"
 [dependencies]
 fontc = { version = "0.0.1", path = "../fontc" }
 
-google-fonts-sources = "0.3.0"
+google-fonts-sources = "0.3.1"
 maud = "0.26.0"
 
 chrono.workspace = true
@@ -23,4 +23,5 @@ serde_yaml.workspace = true
 serde_json.workspace = true
 tempfile.workspace = true
 env_logger.workspace = true
+log.workspace = true
 
diff --git a/fontc_crater/src/ci.rs b/fontc_crater/src/ci.rs
@@ -89,7 +89,7 @@ fn run_crater_and_save_results(args: &CiArgs) -> Result<(), Error> {
     {
         // eventually we will want an argument to force rerunning, which we'll
         // use when we update fontmake or the input data set
-        eprintln!("fontc rev is unchange from last run, skipping");
+        log::info!("fontc rev is unchange from last run, skipping");
         return Ok(());
     }
 
@@ -109,7 +109,7 @@ fn run_crater_and_save_results(args: &CiArgs) -> Result<(), Error> {
         .as_ref()
         .map(Path::new)
         .unwrap_or(temp_dir.path());
-    eprintln!("using working dir {}", cache_dir.display());
+    log::info!("using working dir {}", cache_dir.display());
 
     let began = Utc::now();
     let results = super::run_all(&inputs, cache_dir, super::ttx_diff_runner::run_ttx_diff)?;

diff --git a/fontc_crater/src/main.rs b/fontc_crater/src/main.rs
@@ -222,10 +222,10 @@ fn run_all<T: Send, E: Send>(
             .map(|target| {
                 let i = counter.fetch_add(1, Ordering::Relaxed) + 1;
                 currently_running.fetch_add(1, Ordering::Relaxed);
-                eprintln!("starting {} ({i}/{total_targets})", target.display());
+                log::debug!("starting {} ({i}/{total_targets})", target.display());
                 let r = runner(&target);
                 let n_running = currently_running.fetch_sub(1, Ordering::Relaxed);
-                eprintln!("finished {} ({n_running} active)", target.display());
+                log::debug!("finished {} ({n_running} active)", target.display());
                 let target = target
                     .strip_prefix(cache_dir)
                     .unwrap_or(target.as_path())

diff --git a/fontc_crater/src/ttx_diff_runner.rs b/fontc_crater/src/ttx_diff_runner.rs
@@ -36,7 +36,7 @@ pub(super) fn run_ttx_diff(source: &Path) -> RunResult<DiffOutput, DiffError> {
         Some(2) => match serde_json::from_slice::<RawDiffOutput>(&output.stdout) {
             Err(_) => {
                 let output = String::from_utf8_lossy(&output.stdout);
-                eprintln!("MALFORMED JSON? '{output}'");
+                log::error!("MALFORMED JSON? '{output}'");
                 std::process::exit(1);
             }
             Ok(RawDiffOutput::Success(success)) => {