Merge pull request #764 from googlefonts/marks-context

[marks] Move marks logic into a context struct
googlefonts · Apr 3, 2024 · 949b3b7 · 949b3b7
2 parents bf6167a + 52270d8
commit 949b3b7
Show file tree

Hide file tree

Showing 4 changed files with 226 additions and 153 deletions.
diff --git a/fontbe/src/error.rs b/fontbe/src/error.rs
@@ -79,6 +79,7 @@ pub enum Error {
     #[error("No glyph class '{0}'")]
     MissingGlyphClass(GlyphName),
     #[error("Mark glyph '{glyph}' in conflicting classes '{old_class}' and '{new_class}'")]
+    //FIXME: this can be deleted eventually, we will manually ensure classes are disjoint
     PreviouslyAssignedMarkClass {
         old_class: SmolStr,
         new_class: SmolStr,