Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated mark-to-mark attachment lookups do not work #958

Closed
khaledhosny opened this issue Sep 11, 2024 · 1 comment · Fixed by #960
Closed

Generated mark-to-mark attachment lookups do not work #958

khaledhosny opened this issue Sep 11, 2024 · 1 comment · Fixed by #960

Comments

@khaledhosny
Copy link
Contributor

The generated lookups have mark filtering sets that include only the mark glyphs but not the bases (which are also mark glyphs since this mark-to-mark), as a result the lookups are never applied since the base glyphs will be skipped.
khaledhosny added a commit to khaledhosny/fontc that referenced this issue Sep 11, 2024
@khaledhosny
Add base marks to mark filtering sets of mark-to-mark attachment lookups
e032ce8 
Otherwise the lookups will not be applied as the base marks will be
skipped.

Fixes googlefonts#958
@khaledhosny khaledhosny mentioned this issue Sep 11, 2024
Merged
@khaledhosny
Copy link
Contributor Author

khaledhosny commented Sep 11, 2024 •
edited
Loading

This was rather dramatic, but now I see that they are broken only when the set of marks and bases are different, which might be a little uncommon thing to have.

khaledhosny added a commit to khaledhosny/fontc that referenced this issue Sep 11, 2024
@khaledhosny
Add base marks to mark filtering sets of mark-to-mark attachment lookups
40bae14 
Otherwise the lookups will not be applied as the base marks will be
skipped.

Fixes googlefonts#958
@cmyr cmyr closed this as completed in #960 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add base marks to mark filtering sets of mark-to-mark attachment lookups khaledhosny/fontc
1 participant
@khaledhosny