Add the ability to filter glyphs to be processed #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
force-pushed
the
glyph_filter
branch
3 times, most recently
from
73a1e8c
to
d6c067a
Compare
dfrg
approved these changes
Mar 6, 2023
| .map_err(Error::BadRegex)?; | ||
|
|
||
| if let Some(regex) = &glyph_name_filter { | ||
| current_inputs.glyphs.retain(|glyph_name, _| { |
There was a problem hiding this comment.
Per im, feature compilation requires the full glyph list. Assuming we want to eventually support filtering in combination with features (compile time subsetting?) it might be worth thinking about how we retain the original glyph order and map between that and the filtered set.
There was a problem hiding this comment.
We can store it on Context if it turns out we need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very handy when trying to track down issues with specific glyphs.
Skip features when a glyph filter is active.