New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rough in hmtx #143

Merged

rsheeter merged 4 commits into main from hmtx

Mar 15, 2023

Contributor

rsheeter commented Mar 14, 2023

First pass at hmtx. Contributes to #138.

rsheeter requested a review from anthrotype

March 14, 2023 05:17

rsheeter mentioned this pull request

Compile an MVP font that renders and produces ttx #138

Closed

10 tasks

anthrotype reviewed

View reviewed changes

fontc/src/main.rs Outdated Show resolved Hide resolved

anthrotype reviewed

View reviewed changes

resources/testdata/glyphs2/OneGlyph.glyphs Outdated Show resolved Hide resolved

anthrotype reviewed

View reviewed changes

fontc/src/main.rs Show resolved Hide resolved

anthrotype reviewed

View reviewed changes

fontbe/src/hmtx.rs Outdated Show resolved Hide resolved

anthrotype reviewed

View reviewed changes

fontbe/src/hmtx.rs Outdated Show resolved Hide resolved

rsheeter force-pushed the macrow branch from 301b289 to f8985dc Compare

March 14, 2023 20:58

rsheeter force-pushed the hmtx branch from 701cc46 to 2821a07 Compare

March 15, 2023 04:39

rsheeter added 2 commits

March 14, 2023 21:41


          Rough in hmtx

392b35d


          Adjust messages

5cfe4b9

rsheeter force-pushed the hmtx branch from 2821a07 to 5cfe4b9 Compare

March 15, 2023 04:41

Contributor Author

rsheeter commented Mar 15, 2023

Apologies, had to force push to tidy up merge errors.


          Update to latest macro defs

7356aea

rsheeter mentioned this pull request

Round hmtx properly #147

Closed


          When renaming things it may help to add the file with the new name

Member

anthrotype commented Mar 15, 2023

to tidy up merge errors.

no worries. However, you can always us git merge instead of git rebase while you're working on a PR that's already been partially reviewed, then immediately before actually merging the final LGTM'ed PR you can always do a rebase to restore linear history and clean up the merge commits

anthrotype approved these changes

View reviewed changes

Base automatically changed from macrow to main

March 15, 2023 16:20

Contributor Author

rsheeter commented Mar 15, 2023

you can always us git merge instead of git rebase

I know, but I also know I might forget the cleanup step. Gambling that feedback was largely complete I suppose.

rsheeter merged commit 784a041 into main

rsheeter deleted the hmtx branch

March 15, 2023 16:21

rsheeter added this to the Build a simple, static, font that renders in a browser milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet