Restore the ability to produce a meaningful flamegraph #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
changed the title
anthrotype
approved these changes
Aug 10, 2023
|
Huh that's funny behaviour, I wonder what the rationale is? I did a quick skim of the flamegraph docs and didn't see an option to turn off the thread grouping, so 🤷 In any case, this was part of a patch that included one other change, to how we format log messages, and you'll want to back that out too (see eadad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment of thread names causes each to root individually in flamegraph, making it essentially useless. Note the tp0, 1, etc:
If we don't name them the flamegraph is very useful:
So don't name the threads. If we really like thread names we can make it optional - even on by default - in a followon while also documenting how to get a good flamegraph.
JMM.