Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fontdrasil #79

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Fontdrasil #79

merged 2 commits into from
Jan 11, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Jan 9, 2023 •
edited
Loading

Introduce a crate for things FE and BE both use. Naming based on yggdrasil, the world tree that connects norse realms, to keep the "fontir" style alive.

Intent is a future BE crate will have it's own Context and use the same machinery. Split out of #76.

@rsheeter rsheeter changed the base branch from main to static January 9, 2023 19:19
Base automatically changed from static to main January 9, 2023 19:37
@rsheeter
Move reusable parts of orchestration to fontdrasil.
8c03ae0 
fontdrasil will be shared by FE and BE.
anthrotype
anthrotype approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mostly moves existing stuff to the new crate so LGTM, but see minor comments

cmyr
cmyr approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of nits and observations of unknown value inline. 💁

fontdrasil/src/lib.rs Show resolved Hide resolved
fontdrasil/src/orchestration.rs Outdated Show resolved Hide resolved
fontdrasil/src/orchestration.rs Outdated Show resolved Hide resolved
fontdrasil/src/orchestration.rs Outdated Show resolved Hide resolved
fontdrasil/src/orchestration.rs Outdated Show resolved Hide resolved
fontdrasil/src/orchestration.rs Show resolved Hide resolved
fontdrasil/src/orchestration.rs Outdated Show resolved Hide resolved
fontir/src/orchestration.rs Outdated Show resolved Hide resolved
fontir/src/orchestration.rs Show resolved Hide resolved
fontir/src/orchestration.rs Show resolved Hide resolved
@rsheeter
Copy link
Contributor Author

A bunch of nits and observations of unknown value inline. tipping_hand_person

All much appreciated, helps me learn as well as improving the code

@rsheeter rsheeter mentioned this pull request Jan 11, 2023
Open
@rsheeter rsheeter merged commit 72d0b92 into main Jan 11, 2023
@rsheeter rsheeter deleted the fontdrasil branch January 11, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsheeter @cmyr @anthrotype