[ttx_diff] Add basic support for mark2lig rules #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't handling this at all. This implementation does not do some of the fancier stuff that we do for other mark attachment rules, since these lookups are less common and it seems much less likely that there will be overlapping lookups that apply rules to the same glyphs.
rsheeter
reviewed
May 9, 2024
Comment on lines
+48
to
+58
| write!(f, "{base_name} (lig) [")?; | ||
| for (i, anchor) in self.base_anchors.iter().enumerate() { | ||
| if i != 0 { | ||
| write!(f, ", ")?; | ||
| } | ||
| match anchor { | ||
| Some(a) => write!(f, "{a}"), | ||
| None => write!(f, "<NULL>"), | ||
| }? | ||
| } | ||
| writeln!(f, "]")?; |
There was a problem hiding this comment.
this looks suspiciously likely to be a repetitive pattern, if it is perhaps we could share a fn?
There was a problem hiding this comment.
if we end up repeating it we can always refactor, but this is the last mark attachment rule so I don't anticipate that happening.
rsheeter
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't handling this at all. This implementation does not do some of the fancier stuff that we do for other mark attachment rules, since these lookups are less common and it seems much less likely that there will be overlapping lookups that apply rules to the same glyphs.