Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fontir] Rename SourceError::parse -> custom #856

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[fontir] Rename SourceError::parse -> custom #856

merged 1 commit into from
Jun 26, 2024

Conversation

cmyr
Copy link
Member

@cmyr cmyr commented Jun 26, 2024

per conversation in #855, 'parse' is a confusing name for a constructor. This renames that method for SourceError.

JMM

rsheeter
rsheeter approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@rsheeter rsheeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty, this makes it much easier for a population of at least me :D

@rsheeter rsheeter added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 37637fc Jun 26, 2024
10 checks passed
@rsheeter rsheeter deleted the error-fixups branch June 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsheeter rsheeter rsheeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmyr @rsheeter