Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propagate_anchors: fix mis-named test case, add specific one for *origin anchors #890

Merged
merged 2 commits into from
Aug 5, 2024
Merged

propagate_anchors: fix mis-named test case, add specific one for *origin anchors #890

merged 2 commits into from
Aug 5, 2024

Conversation

anthrotype
Copy link
Member

origin_anchor test case fails at the moment, still investigating why

@anthrotype anthrotype marked this pull request as draft July 31, 2024 18:02
@anthrotype
fix origin_anchor test, sync with values in PropagateAnchorsTest.glyphs
ecc727d 
the inputs to the origin_anchor test are now the same as in the PropagateAnchorsTest.glyphs file and the expected results now match the observed behavior when running the built-in anchorsTraversingComponents method from within Glyphs.app macro panel.
@anthrotype anthrotype marked this pull request as ready for review August 1, 2024 09:49
@anthrotype
Copy link
Member Author

anthrotype commented Aug 1, 2024 •
edited
Loading

The test passes now. The code is correct, the input values were wrong (not matching the expected result).

But I have discovered something interesting relating to the *origin anchor. When you modify its position in the glyph editing view, the composite glyphs that reference that particular glyph you just edited do not immediately respond to the change, but only after they are double-clicked... I think it may have to do with the automatic component alignment feature that keeps components in precomposed glyphs (aacute) anchored to one another through the same anchors that are used for OTL mark positioning, these are also influenced by this *origin anchor but not immediately but only upon them subsequently being edited or modified...
That might explain why the position of acutecomb was kind of out of sync in the original test case (shifted -20 units) compared with its correct position.

@anthrotype anthrotype requested a review from cmyr August 1, 2024 13:33
cmyr
cmyr approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@anthrotype anthrotype added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit d1ff5e3 Aug 5, 2024
10 checks passed
@anthrotype anthrotype deleted the fix-prop-anchors-test branch August 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthrotype @cmyr