must decompose transformed components before flattening deep nested components #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails as expected because the I'll flip the order of the operations now, and the test will pass |
anthrotype
added a commit
that referenced
this pull request
Sep 6, 2024
Fixes #947 The failing test from the previous commit should now pass
…pose-transformed-components flags are set currently we do not thus this test fails (we should run them in inverse order)
Fixes #947 The failing test from the previous commit should now pass
anthrotype
force-pushed
the
decompose-before-flattening
branch
from
a5b7ea4
to
15a8ade
Compare
rsheeter
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #929