Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ttx_diff] Normalize axis labels in fvar and STAT tables #963

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

khaledhosny
Copy link
Contributor

Like it is done for named instance name IDs.

Like it is done for named instance name IDs.
@cmyr
Copy link
Member

cmyr commented Sep 11, 2024

just to sanity check, do you have a link to an example font where this was causing a problem?

@khaledhosny
Copy link
Contributor Author

I’m testing with https://github.com/aliftype/mada/tree/main/sources/, without this change I get the following diff in fvar:

--- fontc.fvar.ttx	2024-09-11 22:19:16
+++ fontmake.fvar.ttx	2024-09-11 22:19:17
@@ -7,7 +7,7 @@
       <MinValue>200.0</MinValue>
       <DefaultValue>400.0</DefaultValue>
       <MaxValue>900.0</MaxValue>
-      <AxisNameID>256</AxisNameID>
+      <AxisNameID>259</AxisNameID>
     </Axis>

     <!-- ExtraLight -->

and STAT:

--- fontc.STAT.ttx	2024-09-11 22:19:16
+++ fontmake.STAT.ttx	2024-09-11 22:19:17
@@ -5,7 +5,7 @@
     <DesignAxisRecord>
       <Axis index="0">
         <AxisTag value="wght"/>
-        <AxisNameID value="256"/>  <!-- Weight -->
+        <AxisNameID value="259"/>  <!-- Weight -->
         <AxisOrdering value="0"/>
       </Axis>
     </DesignAxisRecord>

(the different name IDs are probably caused by #950, but that shouldn’t be relevant)

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@cmyr cmyr added this pull request to the merge queue Sep 11, 2024
Merged via the queue into googlefonts:main with commit a9b69b2 Sep 11, 2024
9 of 10 checks passed
@khaledhosny khaledhosny deleted the ttx_diff-names branch September 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants