-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do we include space, nb space and some control chars in extended subsets? #14
Comments
@garretrieger would you be opposed to me removing the following glyphs from every extended subset, https://github.com/googlefonts/nam-files/blob/main/Lib/gfsubsets/data/greek-ext_unique-glyphs.nam#L5-L8. My issue is that |
Removing codepoints from a subset that have been included in pushed fonts can be risky, so if the only problem these are causing is with the tools then I'd prefer we try updating the tools first before resorting to subset changes. |
I think it would be reasonable to just ignore those four characters for the purpose of subset selection as they occur frequently in various subsets and don't really signal any specific script. |
I think this is also the case for Edit: At a revision of the |
I'll make a fix for this today. Plan is to simply make the mod to the tools. |
These character are already covered in the non-extended subsets so I don't see the point in duplicating them?
The text was updated successfully, but these errors were encountered: