instructionCompiler: don't log about .notdef missing

this is just noise and may be confusing for the user. .notdef glyph is often automatically generated by ufo2ft, in which case of course it's missing from the source UFOs, there's no need for instructionCompiler to add noise to the already busy fontmake output...
googlefonts · Sep 8, 2023 · d3613d8 · d3613d8
1 parent b3895a9
commit d3613d8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/Lib/ufo2ft/instructionCompiler.py b/Lib/ufo2ft/instructionCompiler.py
@@ -109,11 +109,13 @@ def compileGlyphInstructions(self, ttGlyph, name) -> None:
         """Compile the glyph instructions from the UFO glyph `name` to bytecode
         and add it to `ttGlyph`."""
         if name not in self.ufo:
-            # Skip glyphs that are not in the UFO, e.g. '.notdef'
-            logger.info(
-                f"Skipping compilation of instructions for glyph '{name}' because it "
-                "is not in the input UFO."
-            )
+            # Skip glyphs that are not in the UFO; no need to inform about '.notdef'
+            # since that glyph is often auto-generated
+            if name != ".notdef":
+                logger.info(
+                    f"Skipping compilation of instructions for glyph '{name}' because it "
+                    "is not in the input UFO."
+                )
             return
 
         glyph = self.ufo[name]

diff --git a/tests/instructionCompiler_test.py b/tests/instructionCompiler_test.py
@@ -281,11 +281,18 @@ def test_compile_program(self, quadufo):
 
     def test_compileGlyphInstructions_missing_glyph(self, caplog):
         # The method logs an info when trying to compile a glyph which is
-        # missing in the UFO, e.g. '.notdef'
+        # missing in the UFO
         ic = InstructionCompiler(dict(), None)
         with caplog.at_level(logging.INFO, logger="ufo2ft.instructionCompiler"):
             ic.compileGlyphInstructions(None, "A")
         assert "Skipping compilation of instructions for glyph 'A'" in caplog.text
+        # ... except for '.notdef' which is frequently generated
+        with caplog.at_level(logging.INFO, logger="ufo2ft.instructionCompiler"):
+            ic.compileGlyphInstructions(None, ".notdef")
+        assert (
+            "Skipping compilation of instructions for glyph '.notdef'"
+            not in caplog.text
+        )
 
     # _compile_tt_glyph_program