-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instructionCompiler: "Number of components" message should be toned down #743
Comments
Do the UFOs have explicit composite flags? Probably the InstructionCompiler shouldn't care about the number of components changing if it the flags are set automatically. |
it seems like InstructionCompiler currently issues that warning regardless of whether we are setting the flags automatically or not. I think we should only issue the warning when we are setting the flags manually (autoUseMyMetrics is not True) |
…noisy We should only issue this warning when USE_MY_METRICS flags are set manually from the UFO. Fixes #743
…noisy We should only issue this warning when USE_MY_METRICS flags are set manually from the UFO. Fixes #743
I think it's not only USE_MY_METRICS. The original components may have had other flags that cannot be set in the TTF when the number of components has changed. |
hm but the warning is issued just before calling autoUseMyMetrics on that component... |
I'd also be ok to just completely remove the logging message or demote it to DEBUG |
+1 for removing it, I'll make a PR. |
Thinking about it again, I came to the conclusion that a debug message makes more sense. In case anyone wonders why the flags are set differently than expected ... |
I'm getting flooded with these messages when using the flattening filter. Maybe the warning shouldn't be fired then or made a debug message.
The text was updated successfully, but these errors were encountered: