add allQuadratic=False option to allow building glyf v1 with cubics #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a mix of cubics or quadratic depending on which is more economical
|
Should it also set the glyf version to 1? |
|
github acting weird 😞
|
anthrotype
force-pushed
the
not-all-quadratic
branch
from
01fdc7e
to
ea4d3eb
Compare
probably yeah |
behdad
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that is, a mix of cubics or quadratic depending on which is more economical. In practice, all cubics are kept as such and only converted to quad if they can be approximated by a single quad (1 off-curve point vs original 2)