add convertCubics to compileVariable; check no cubics if glyphDataFormat=0 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compileTTF already had a way to completely skip cu2qu, but the interpolatable/variable compile paths did not. Add it
to prevent one inadvertently produce an invalid TTF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compileTTF (for static TTF builds) already have a
convertCubics=Truethat when set to False completely skips the cu2qu.So I added one for the compileInterpolatableTTF/compileVariableTTF methods as well, so that from fontmake one can request to pass through the cubics unchanged.
Also I made so the OutlineTTFCompiler checks that if glyphDataFormat=0, then no cubic flags are set and raise an error in they do, prompting to either convert to quadratic or to explicitly allow allQuadratic=False (which in turn sets glyphDataFormat=1). This is to prevent from accidentally building glyf v1 table.