allow to reverseDirection without convertCubics #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
reverse-direction-filter
branch
from
b679860
to
90b00c7
Compare
anthrotype
force-pushed
the
reverse-direction-filter
branch
from
90b00c7
to
5263d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously reverseDirection option was handled exclusively within cu2qu, but since convertCubics=False allows one to skip cu2qu altogether, it'd become impossible to do the reversing independently from the cu2qu conversion. So I added a separate filter that does the reversing (using the fontTools ReverseContourPointPen) used only when convertCubics=False and reverseDirection=True.