set OVERLAP_SIMPLE when public.truetype.overlap key set on simple glyph #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hate when we get completely random flake8 failures out of the blue because it gets updated upstream.. we should pin it!
|
Good catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were only reading the UFO
public.truetype.overlapkey for composite glyphs, but not also for simple contour glyphs.This PRs adds support for that as well.
Fixes/supersedes Fixes #615
https://unifiedfontobject.org/versions/ufo3/glyphs/glif/#publictruetypeoverlap
/cc @jenskutilek @m4rc1e